Juan Hernandez has posted comments on this change. Change subject: 8. core: Use new authentication interfaces ......................................................................
Patch Set 31: (1 comment) http://gerrit.ovirt.org/#/c/20412/31/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 145: profileName Line 146: ); Line 147: for (VdcBllMessages msg : result.resolveMessage()) { Line 148: addCanDoActionMessage(msg); Line 149: } I think that here we should map what the authenticator returns to a VdcBllMessage, but the authenticator should not depend on VdcBllMessag. We can do something like this: // Try to get a VdcBllMessage code from the authenticator, if // it supports that (note that we are inventing the MIME type): String detail = result.getDetail("application/ovirt-bll-message", null); if (detail != null) { VdcBllMessage message = VdcBllMessage.valueOf(detail); addCanDoActionMessage(message); } // If the authenticator doesn't support BLL messages then // use a generic one: else { adCanDoActionMessage(VdcBllMessages.USER_FAILED_TO_AUTHENTICATE); } This way the authenticator infrastructure is not tied to the VdcBllMessages class, but can still support it. Line 150: return false; Line 151: } Line 152: Line 153: // Check that the user exists in the directory associated to the authentication profile: -- To view, visit http://gerrit.ovirt.org/20412 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d5d6ee41b5373328eaf2f8448efe8e598609651 Gerrit-PatchSet: 31 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
