Lior Vernia has posted comments on this change. Change subject: webadmin: Acknowledge labels in Setup Networks dialog ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/22971/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 591: } Line 592: } Line 593: Line 594: // does this nic have any labels? Line 595: Set<String> labels = nic.getLabels(); > Just meant to extract the entire code that handles labels and split it a bi Ended up not extracting it at the moment because it would require passing the local map variables to the method as well, which isn't so elegant. Will have a think on this whole initNicModels() method in the future. Line 596: if (labels != null) { Line 597: for (String label : labels) { Line 598: NetworkLabelModel labelModel = labelMap.get(label); Line 599: if (labelModel != null) { -- To view, visit http://gerrit.ovirt.org/22971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e7d712fcae59b4e03ff365408161f5472dc235d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
