Piotr Kliczewski has posted comments on this change. Change subject: tools: reorganize packages ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/23153/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 15: import org.ovirt.engine.core.notifier.dao.EventsManager; Line 16: import org.ovirt.engine.core.notifier.utils.NotificationMethodsMapper; Line 17: import org.ovirt.engine.core.notifier.utils.NotificationProperties; Line 18: Line 19: import org.ovirt.engine.core.notifier.sender.*; Is there a reason to need all the classes from this package? Line 20: /** Line 21: * Responsible for an execution of the service for the current events in the system which should be notified to the Line 22: * subscribers. Line 23: */ http://gerrit.ovirt.org/#/c/23153/3/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/EventSender.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/EventSender.java: Line 1: package org.ovirt.engine.core.notifier.sender; Line 2: Line 3: import org.ovirt.engine.core.common.businessentities.AuditLogEvent; Line 4: import org.ovirt.engine.core.common.businessentities.AuditLogEventSubscriber; Line 5: It is nice to have javadocs at the interface level for future implementations. Line 6: public interface EventSender { Line 7: Line 8: public EventSenderResult send(AuditLogEvent auditLogEvent, AuditLogEventSubscriber AuditLogEventSubscriber); Line 9: -- To view, visit http://gerrit.ovirt.org/23153 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8ad76f4fdc9d065eaa8380fba68a2a86f8410fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
