Lior Vernia has posted comments on this change. Change subject: webadmin: Simplify mapping in Setup Networks initialization ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/22970/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 502: Line 503: // pass over all nics Line 504: for (VdsNetworkInterface nic : allNics) { Line 505: // is this a management nic? (comes from backend) Line 506: boolean isNicManagement = nic.getIsManagement(); > all should be final? Done Line 507: final String nicName = nic.getName(); Line 508: final String networkName = nic.getNetworkName(); Line 509: final String bondName = nic.getBondName(); Line 510: final Integer vlanId = nic.getVlanId(); Line 510: final Integer vlanId = nic.getVlanId(); Line 511: final int dotpos = nicName.indexOf('.'); Line 512: Line 513: // is this a physical nic? Line 514: boolean isPhysicalInterface = vlanId == null; > worth neglecting the flag as it used only once.. Done Line 515: Line 516: // bridge name is either <nic>, <nic.vlanid> or <bond.vlanid> Line 517: String ifName; Line 518: if (dotpos > 0) { Line 512: Line 513: // is this a physical nic? Line 514: boolean isPhysicalInterface = vlanId == null; Line 515: Line 516: // bridge name is either <nic>, <nic.vlanid> or <bond.vlanid> > Probably not related to the patch, but this check isn't pretty :) Yeah, I'll take a look at alternatives in the future. Line 517: String ifName; Line 518: if (dotpos > 0) { Line 519: ifName = nicName.substring(0, dotpos); Line 520: } else { -- To view, visit http://gerrit.ovirt.org/22970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia29636b437262301996a459f017d2260680e708f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
