Gilad Chaplik has posted comments on this change.

Change subject: core,engine,webadmin: Automatic power management of hosts
......................................................................


Patch Set 11: -Code-Review

(1 comment)

taking back the +2 for a second, needs to add it to tags view.

http://gerrit.ovirt.org/#/c/22376/11/packaging/dbscripts/create_views.sql
File packaging/dbscripts/create_views.sql:

Line 744:                       CASE WHEN storage_pool.spm_vds_id = 
vds_static.vds_id THEN CASE WHEN storage_pool.status = 5 THEN 1 ELSE 2 END ELSE 
0 END AS
Line 745: spm_status, vds_dynamic.supported_cluster_levels, 
vds_dynamic.supported_engines,
Line 746:                       vds_groups.compatibility_version AS 
vds_group_compatibility_version, vds_dynamic.host_os, vds_dynamic.kvm_version, 
vds_dynamic.libvirt_version,
Line 747:                       vds_dynamic.spice_version, 
vds_dynamic.gluster_version, vds_dynamic.kernel_version, 
vds_dynamic.iscsi_initiator_name,
Line 748:                       vds_dynamic.transparent_hugepages_state, 
vds_statistics.anonymous_hugepages, vds_dynamic.non_operational_reason,
add it to this view as well, it is rarely used but still.
Line 749:                       storage_pool_iso_map.storage_id, 
vds_static.ssh_port, vds_static.ssh_username, vds_statistics.ha_score as 
ha_score
Line 750: FROM         vds_groups INNER JOIN
Line 751: vds_static ON vds_groups.vds_group_id = vds_static.vds_group_id INNER 
JOIN
Line 752: vds_dynamic ON vds_static.vds_id = vds_dynamic.vds_id INNER JOIN


-- 
To view, visit http://gerrit.ovirt.org/22376
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icdea8bdef15556be1591ffb7554f79238f865ec8
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to