Allon Mureinik has posted comments on this change. Change subject: engine: Add caching capabilities to DAOs ......................................................................
Patch Set 3: (2 comments) what's the relationship between this cache and ./backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/cache/CacheManager.java ? why do we need both? Shouldn't this cache use the CacheManager? http://gerrit.ovirt.org/#/c/21952/3//COMMIT_MSG Commit Message: Line 9: This patch creates the ability to cache DAOs, and specifically Line 10: VdsStatic, VdsGroup and vds_spm_id_map. Line 11: Line 12: Change-Id: Id3354858d67f20661363cccc60380119c30e12ba Line 13: Bug-Url: https://bugzilla.redhat.com/?????? please remove this http://gerrit.ovirt.org/#/c/21952/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java: Line 370 Line 371 Line 372 Line 373 Line 374 unrelated to the patch - just adds extra noise. please remove. -- To view, visit http://gerrit.ovirt.org/21952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3354858d67f20661363cccc60380119c30e12ba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
