Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: compare minimal version correctly ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/22831/2/etl_export/src/ovirt_engine_dwh/minimalversioncheck_3_4/MinimalVersionCheck.java File etl_export/src/ovirt_engine_dwh/minimalversioncheck_3_4/MinimalVersionCheck.java: Line 1168: } Line 1169: Line 1170: if (!context.ovirtMinimalETL.substring(0, 3).equals( Line 1171: context.etlVersion.substring(0, 3)) Line 1172: || (context.ovirtMinimalETL.substring(0, 3).equals( I suggest you split by '.' and so you support 3.33 Line 1173: context.etlVersion.substring(0, 3)) && Integer Line 1174: .parseInt(context.ovirtMinimalETL.substring(4)) > Integer Line 1175: .parseInt(context.etlVersion.substring(4)))) { Line 1176: -- To view, visit http://gerrit.ovirt.org/22831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a5e86d87d0f59abfad7c82b40c5695545b86e1d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
