Martin Peřina has posted comments on this change. Change subject: tools: remove auxiliary email address from EventSender interface ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/23106/5/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java: Line 255: } Line 256: Line 257: private event_notification_hist geteventNotificationHist(EventAuditLogSubscriber eals, Line 258: boolean isNotified, Line 259: String reason) { Please leave formatting as it was, it's pretty standard in Java Line 260: event_notification_hist eventHistory = new event_notification_hist(); Line 261: eventHistory.setaudit_log_id(eals.getaudit_log_id()); Line 262: eventHistory.setevent_name(eals.getevent_up_name()); Line 263: eventHistory.setmethod_type(eals.getEventNotificationMethod().name()); Line 275: eals.setevent_up_name(rs.getString("event_up_name")); Line 276: eals.setEventNotificationMethod(EventNotificationMethod.valueOf(rs.getString("notification_method"))); Line 277: String methodAddress = rs.getString("method_address"); Line 278: if (methodAddress == null) { Line 279: What is this condition with empty body for? Line 280: } Line 281: eals.setmethod_address(methodAddress); Line 282: eals.settag_name(rs.getString("tag_name")); Line 283: eals.setaudit_log_id(rs.getLong("audit_log_id")); -- To view, visit http://gerrit.ovirt.org/23106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic69ff7541fca8347fb7cb85665934ca704fa9d06 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
