Gilad Chaplik has posted comments on this change.

Change subject: core: remove VM from its Affinity Group on change cluster
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/22740/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java:

Line 223:             StringBuilder sb = new StringBuilder();
Line 224:             for (AffinityGroup affinityGroup : 
allAffinityGroupsByVmId) {
Line 225:                 sb.append(affinityGroup.getName() + " ");
Line 226:             }
Line 227:             log.infoFormat("Removing VM from associated affinity 
groups: {0}", sb.toString());
> Please rephrase:
the command is specified in the log, but there's no harm in that.

Done.
Line 228:             
DbFacade.getInstance().getAffinityGroupDao().removeVmFromAffinityGroups(vm.getId());
Line 229:         }
Line 230:         setSucceeded(true);
Line 231:     }


-- 
To view, visit http://gerrit.ovirt.org/22740
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cc4f8ea49b4c79aea4d16239e09d2db8a07bd8a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to