Moti Asayag has posted comments on this change. Change subject: engine: Setup multiple iscsi sessions with the iscsi target ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23198/3/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java: Line 367: public void testGetIscsiInitiatorsByHostIdAndStorageTargetId() { Line 368: List<VdsNetworkInterface> interfaces = Line 369: dao.getIscsiInitiatorsByHostIdAndStorageTargetId(VDS_ID, TARGET_ID); Line 370: assertNotNull(interfaces); Line 371: assertTrue(interfaces.size() == 1); Either use assertEquals() or better just verify at least a single nic returned: assertFalse(interface.isEmpty()) ; in addition, you could iterate over the interfaces and verify that all of them belong to the desired hosts: for (VdsNetworkInterface nic : interfaces) { assertEquals(VDS_ID, nic.getVdsId()); } Line 372: } -- To view, visit http://gerrit.ovirt.org/23198 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I779f6dd95dfbfc2b74ad7ba3ce2271b7c9ad94db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
