Ramesh N has posted comments on this change. Change subject: gluster: dao changes for volume capacity info ......................................................................
Patch Set 7: (5 comments) http://gerrit.ovirt.org/#/c/23010/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java: Line 104: fetchBrickDetails(brick); Line 105: } Line 106: } Line 107: Line 108: private void fetchBrickDetails(GlusterBrickEntity brick) { > One fetch method below returns a value whereas this method updates into the Done Line 109: if (brick != null) { Line 110: BrickProperties brickProperties = fetchBrickProperties(brick.getId()); Line 111: if (brickProperties != null) { Line 112: BrickDetails brickDetails = new BrickDetails(); Line 240: public BrickProperties mapRow(ResultSet rs, int rowNum) Line 241: throws SQLException { Line 242: BrickProperties brickProperties = new BrickProperties(); Line 243: brickProperties.setTotalSize(rs.getLong("total_space")); Line 244: // brickProperties.setUsedSize(rs.getLong("used_space")); TODO: Can we add usedSize as a brick properties > Remove the commented line Shubhendu: Currently there is no field in BrickProperties to store the usedSize. What do we need here?. Can we add a new field usedSize?. or we can left the UI to calculate. What will you suggest?. Line 245: brickProperties.setFreeSize(rs.getLong("free_space")); Line 246: return brickProperties; Line 247: } Line 248: } http://gerrit.ovirt.org/#/c/23010/7/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDaoTest.java: Line 396: existingReplVol.removeTransportType(TransportType.RDMA); Line 397: assertEquals(volumeAfter, existingReplVol); Line 398: } Line 399: Line 400: > Remove the blank line Done Line 401: private GlusterVolumeEntity insertTestVolume() { Line 402: Guid volumeId = Guid.newGuid(); Line 403: Line 404: GlusterVolumeEntity volume = new GlusterVolumeEntity(); http://gerrit.ovirt.org/#/c/23010/7/packaging/dbscripts/gluster_volumes_sp.sql File packaging/dbscripts/gluster_volumes_sp.sql: Line 161: WHERE task_id = v_task_id; Line 162: END; $procedure$ Line 163: LANGUAGE plpgsql; Line 164: Line 165: Create or replace FUNCTION GetGlusterVolumeDetailsByID(v_volume_id UUID) > %s/GetGlusterVolumeDetailsByID/GetGlusterVolumeDetailsById/g Done Line 166: RETURNS SETOF gluster_volume_details STABLE Line 167: AS $procedure$ Line 168: BEGIN Line 169: RETURN QUERY SELECT * Line 226: ORDER BY brick_order; Line 227: END; $procedure$ Line 228: LANGUAGE plpgsql; Line 229: Line 230: Create or replace FUNCTION GetBrickDetailsByID(v_brick_id UUID) > %s/GetBrickDetailsByID/GetBrickDetailsById/g Done Line 231: RETURNS SETOF gluster_volume_brick_details STABLE Line 232: AS $procedure$ Line 233: BEGIN Line 234: RETURN QUERY SELECT * -- To view, visit http://gerrit.ovirt.org/23010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
