Alissa Bonas has posted comments on this change. Change subject: core: use template version on add vm/pool ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/22975/1/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java: Line 245: .addValue("vnic_profile_id", vnicProfileId)); Line 246: } Line 247: Line 248: @Override Line 249: public VmTemplate getTemplateWithLatestVersionInChain(Guid id) > i wanted it to be clear it latest for the given id, not some global latest, I'd probably name it something like "getLatestTemplateVersion". Line 250: { Line 251: return getCallsHandler().executeRead("GetTemplateWithLatestVersionInChain", Line 252: VMTemplateRowMapper.instance, Line 253: getCustomMapSqlParameterSource() -- To view, visit http://gerrit.ovirt.org/22975 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d1b3ee9cd64d73866762fbf5fe02a468cdd578e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
