Juan Hernandez has posted comments on this change.
Change subject: engine: findbugs: Handling static members
......................................................................
Patch Set 2:
(2 comments)
The changes to the RESTAPI actually increase the visibility of some constants.
Not a big issue, but if possible I would prefer if you can leave the
"protected" there and add the findbugs exclusion to that specific module.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
Line 36: public class BackendVmDisksResource
Line 37: extends AbstractBackendDevicesResource<Disk, Disks,
org.ovirt.engine.core.common.businessentities.Disk>
Line 38: implements VmDisksResource {
Line 39:
Line 40: static final String[] SUB_COLLECTIONS = {"permissions",
"statistics"};
This actually increases the visibility of this constant.
Line 41:
Line 42: public BackendVmDisksResource(Guid parentId,
Line 43: VdcQueryType queryType,
Line 44: VdcQueryParametersBase queryParams) {
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
Line 32: public class BackendGlusterVolumesResource
Line 33: extends AbstractBackendCollectionResource<GlusterVolume,
GlusterVolumeEntity>
Line 34: implements GlusterVolumesResource {
Line 35:
Line 36: static final String[] SUB_COLLECTIONS = { "bricks" };
This actually increases the visibility of the constant.
Line 37: private ClusterResource parent;
Line 38: private String clusterId;
Line 39:
Line 40: public BackendGlusterVolumesResource() {
--
To view, visit http://gerrit.ovirt.org/23176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b940a5e0e25ae4c9488eb32250dc20700d6cd25
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
