Gilad Chaplik has posted comments on this change.

Change subject: engine: Update Power Saving policy with power management
......................................................................


Patch Set 4:

(2 comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PowerSavingBalancePolicyUnit.java
Line 71:         if (targetStatus == VDSStatus.Maintenance && currentStatus == 
VDSStatus.Up) {
Line 72:             logAction(vds, AuditLogType.PM_POLICY_UP_TO_MAINTENANCE);
Line 73: 
Line 74:             /* Up -> Maint */
Line 75:             List<Guid> vdsList = new ArrayList<>(1);
use Arrays.asList()
Line 76:             vdsList.add(vds.getId());
Line 77:             MaintenanceNumberOfVdssParameters parameters = new 
MaintenanceNumberOfVdssParameters(vdsList, true, true);
Line 78:             
Backend.getInstance().runInternalAction(VdcActionType.MaintenanceNumberOfVdss,
Line 79:                     parameters,


Line 122:             @Override
Line 123:             public boolean eval(VDS vds) {
Line 124:                 return vds.getStatus() == VDSStatus.Up
Line 125:                         && vds.getVmCount() == 0
Line 126:                         && vds.getVmMigrating() == 0
that is a mark for the first comment in this page.
Line 127:                         && vds.getPendingVmemSize() == 0
Line 128:                         && vds.getPendingVcpusCount() == 0;
Line 129:             }
Line 130:         });


-- 
To view, visit http://gerrit.ovirt.org/22488
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2da9f4e019c3dd006caefbaa9baf9a533ce41f3d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to