Frank Kobzik has posted comments on this change. Change subject: restapi: Allow enabling/disabling SSO ......................................................................
Patch Set 4: (1 comment) .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/SsoMapper.java Line 26: // set to none if and only if methods list is empty (size 0) Line 27: if (model != null && model.getMethods() != null && model.getMethods().getMethods() != null && model.getMethods().getMethods().size() == 0) { Line 28: return SsoMethod.NONE; Line 29: } Line 30: changed to return null on non-recognized value. Line 31: return SsoMethod.GUEST_AGENT; Line 32: } Line 33: -- To view, visit http://gerrit.ovirt.org/21911 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mishka8...@yahoo.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches