Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: rpm-distro: allow use by other packages
......................................................................


Patch Set 1:

(2 comments)

....................................................
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/__init__.py
Line 16: #
Line 17: 
Line 18: 
Line 19: """ ovirt-host-setup distro-rpm plugin.
Line 20:     Includes code relevant for rpm-based distributions
this is a copy... BTW: I am for removing these comments if there are not useful.

will fix.
Line 21: """
Line 22: 
Line 23: 
Line 24: from otopi import util


....................................................
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py
Line 43:     Package upgrade plugin.
Line 44:     """
Line 45: 
Line 46:     class VersionLockTransaction(transaction.TransactionElement):
Line 47:         """version lock transaction element.
Done
Line 48:         Not that this is real transaction, but we need to
Line 49:         rollback/commit same as packager.
Line 50:         We cannot actually prepare the transaction at prepration
Line 51:         because new packages are not installed.


-- 
To view, visit http://gerrit.ovirt.org/23122
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e4ad1c7f08d0a41742bc44c2ae469c6074cb768
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to