Michael Kublin has posted comments on this change. Change subject: core: Use getAllForVm to filter by allow snapshot ......................................................................
Patch Set 2: (3 inline comments) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskDao.java Line 6: import org.ovirt.engine.core.common.businessentities.DiskImage; why DiskImage is here? Line 29: */ First of all, we are still writing at Java, why u insert public? Second, boolean primitive is not enough? U need big Boolean? why? Why u need true/false and null value? Line 45: */ same here -- To view, visit http://gerrit.ovirt.org/4229 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8911ecd8a25167cb8085a14dba08440f3c2695aa Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
