[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: Small ScrollableTabBar improvements

[vszocs]

Vojtech Szocs has uploaded a new change for review.

Change subject: webadmin,userportal: Small ScrollableTabBar improvements
......................................................................

webadmin,userportal: Small ScrollableTabBar improvements

1. ScrollableTabBarView:
   - removed "implements HasLoadHandlers"
   - removed fireEvent + addLoadHandler methods
   - the "+1 width adjustment" comment moved to
     appropriate location

2. ModelBoundTab:
   - added setAccessible override that fires
     TabAccessibleChangeEvent whenever tab's
     accessibility changes

Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
2 files changed, 15 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/04/23104/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
index 6077371..dddf30c 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
@@ -9,11 +9,7 @@
 import com.google.gwt.dom.client.Style.Unit;
 import com.google.gwt.event.dom.client.ClickEvent;
 import com.google.gwt.event.dom.client.ClickHandler;
-import com.google.gwt.event.dom.client.HasLoadHandlers;
-import com.google.gwt.event.dom.client.LoadHandler;
 import com.google.gwt.event.logical.shared.AttachEvent;
-import com.google.gwt.event.shared.GwtEvent;
-import com.google.gwt.event.shared.HandlerRegistration;
 import com.google.gwt.resources.client.CssResource;
 import com.google.gwt.uibinder.client.UiBinder;
 import com.google.gwt.uibinder.client.UiField;
@@ -26,7 +22,7 @@
 import com.google.gwt.user.client.ui.PushButton;
 import com.google.gwt.user.client.ui.Widget;
 
-public class ScrollableTabBarView extends AbstractView implements 
ScrollableTabBarPresenterWidget.ViewDef, HasLoadHandlers {
+public class ScrollableTabBarView extends AbstractView implements 
ScrollableTabBarPresenterWidget.ViewDef {
 
     public interface ViewUiBinder extends UiBinder<Widget, 
ScrollableTabBarView> {
         ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class);
@@ -216,7 +212,6 @@
      * right floating tabs.
      */
     private void recalculateWidgetBarMinWidth() {
-        // Add 1 for browsers that don't report width properly.
         widgetBar.getElement().getStyle().setProperty(MIN_WIDTH_STYLE, 
calculateWidgetMinWidthNeeded(), Unit.PX);
     }
 
@@ -245,9 +240,10 @@
                 }
             }
         }
+        // Add 1 for browsers that don't report width properly.
+        minWidth++;
         // Store this in a variable so we don't have to calculate it all the 
time.
         // This assumes that when resizes/etc happen this gets called to 
recalculate everything.
-        minWidth++;
         widgetMinWidth = minWidth;
         return minWidth;
     }
@@ -401,15 +397,4 @@
         showScrollButtons();
     }
 
-    @Override
-    public void fireEvent(GwtEvent<?> event) {
-        // TODO Auto-generated method stub
-
-    }
-
-    @Override
-    public HandlerRegistration addLoadHandler(LoadHandler handler) {
-        // TODO Auto-generated method stub
-        return null;
-    }
 }
diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
index 2e709c3..1f2000d 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
@@ -14,6 +14,7 @@
 import com.google.gwt.event.shared.HasHandlers;
 
 public class ModelBoundTab extends SimpleTab implements HasHandlers {
+
     private final EventBus eventBus;
 
     public ModelBoundTab(final ModelBoundTabData tabData, AbstractTabPanel 
tabPanel, EventBus eventBus) {
@@ -49,13 +50,23 @@
                     boolean isAvailable = 
modelProvider.getModel().getIsAvailable();
                     setAccessible(isAvailable);
                 }
-                TabAccessibleChangeEvent.fire(ModelBoundTab.this, 
ModelBoundTab.this);
             }
         });
+    }
+
+    @Override
+    public void setAccessible(boolean accessible) {
+        boolean wasAccessible = isAccessible();
+        super.setAccessible(accessible);
+
+        if (accessible != wasAccessible) {
+            TabAccessibleChangeEvent.fire(this, this);
+        }
     }
 
     @Override
     public void fireEvent(GwtEvent<?> event) {
         eventBus.fireEvent(event);
     }
+
 }


-- 
To view, visit http://gerrit.ovirt.org/23104
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches