Michael Burns has posted comments on this change.

Change subject: Replace centos macro for rhel
......................................................................


Patch Set 1: Code-Review-1

I would see if there is some other way to figure out if you're in koji.  I 
think something like %{epel} or %{koji}, but I don't know if they exist or not. 
 

something like:

if centos or (koji and rhel)

if centos or epel


If there isn't a way to do that, i'd drop the Requires: vdsm-vhostmd line 
completely from the spec and simply add the requires to the RHEL specfile.

-- 
To view, visit http://gerrit.ovirt.org/23097
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a6a6086afec7d06df464f843e86679cb8b7b80e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabi...@fedoraproject.org>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to