Alissa Bonas has posted comments on this change.
Change subject: core: import/export from template version
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
Line 501:
Line 502: node = content.SelectSingleNode("templateVersion");
Line 503: if (node != null) {
Line 504: if (!StringUtils.isEmpty(node.innerText)) {
Line 505:
vmBase.setTemplateVersion(Integer.parseInt(node.innerText));
if parseInt method will throw NumberFormatException, is it treated properly?
Line 506: }
Line 507: }
Line 508:
Line 509: readGeneralData(content);
--
To view, visit http://gerrit.ovirt.org/22737
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dd434f5857a707f12508ebb6ab20e46a4f1be3c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
