Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: legacy: use postgres db user ......................................................................
Patch Set 1: Code-Review+1 (1 comment) I +1 that, however, I really think that if we find one issue in this code we will have another. So best to read the legacy config file, acquire the user name and fetch this user and only this user from pgpass. .................................................... File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/database.py Line 86 Line 87 Line 88 Line 89 Line 90 yes... now I am asking... i think that configfile can read the legacy config at sysconfig without any problem. so it can be quite simple to achieve this without guessing. -- To view, visit http://gerrit.ovirt.org/23055 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I391cc532fd1673db9f6adb29fc0cce052992fda4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
