Vitor de Lima has posted comments on this change.

Change subject: core, engine, restapi: Proper default migration policies for 
ppc64
......................................................................


Patch Set 4:

(1 comment)

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
Line 119:                 }
Line 120: 
Line 121:                 if (!vm.isSetPlacementPolicy() && 
templateId.equals(Guid.Empty)) {
Line 122:                     staticVm.setMigrationSupport(null);
Line 123:                 }
This rule makes the AddVmCommand auto-select the migration policy for this VM 
only if no migration policy was explicitly set in the incoming XML and the 
select template was the blank one. Otherwise this parameter is obtained from 
the XML or from the template. How do you suggest I implement this behaviour?
Line 124: 
Line 125:                 Guid storageDomainId =
Line 126:                         (vm.isSetStorageDomain() && 
vm.getStorageDomain().isSetId()) ? asGuid(vm.getStorageDomain()
Line 127:                                 .getId())


-- 
To view, visit http://gerrit.ovirt.org/21643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib34c4a01fe0c667bafc47bf70b33bb2990ffb7d3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa 
<gustavo.pedr...@eldorado.org.br>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to