Alon Bar-Lev has uploaded a new change for review.

Change subject: packaging: services: remove pid when service start fails
......................................................................

packaging: services: remove pid when service start fails

the service is running under non privileged user, so it cannot remove
the pid file only clear it.

if service is dead at validation stage its status is printed as:

  dead but pid file exists

to remedy that, if service fails to start we remove the pid if service
start fails and pid file is zero length.

Change-Id: I11a29e58e0fd673eb1df79983b0c09799f9ef0f3
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.sysv.in
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-dwh refs/changes/74/23074/1

diff --git a/packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.sysv.in 
b/packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.sysv.in
index 41de736..e9327a8 100644
--- a/packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.sysv.in
+++ b/packaging/services/ovirt-engine-dwhd/ovirt-engine-dwhd.sysv.in
@@ -51,6 +51,7 @@
                                RETVAL=0
                        fi
                fi
+               [ $RETVAL -ne 0 -a ! -s "${PIDFILE}" ] && rm -f "${PIDFILE}"
                ;;
        stop)
                echo -n $"Stopping $PROG: "


-- 
To view, visit http://gerrit.ovirt.org/23074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I11a29e58e0fd673eb1df79983b0c09799f9ef0f3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to