Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: database: apply indirect reference to db vars
......................................................................
Patch Set 1:
(1 comment)
....................................................
File packaging/setup/ovirt_engine_setup/database.py
Line 295: self.command.detect('psql')
Line 296:
Line 297: def createPgPass(self):
Line 298: fd, pgpass = tempfile.mkstemp()
Line 299: atexit.register(os.unlink, pgpass)
I wanted to avoid explicit call to this module in different phases, so as this
is pure temp file I preferred to auto clean it. had there decent destructors in
python I would have used these...
is there any advantage you see in calling this from cleanup stage?
I set this late in environment so that if there is an error, we will not have
it set in environment. you can argue that I am too anxious.
Line 300: with os.fdopen(fd, 'w') as f:
Line 301: f.write(
Line 302: (
Line 303: '# DB USER credentials.\n'
--
To view, visit http://gerrit.ovirt.org/22987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I587c287d822a7ea8e7ebf34ca70960172edc3fbc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
