Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: prefix database related messages with 'Engine'
......................................................................


Patch Set 1:

(3 comments)

....................................................
File packaging/setup/ovirt_engine_setup/constants.py
Line 722: 
Line 723:     @osetupattrs(
Line 724:         answerfile=True,
Line 725:         summary=True,
Line 726:         description=_('Engine Datbase port'),
Done
Line 727:     )
Line 728:     def PORT(self):
Line 729:         return 'OVESETUP_DB/port'
Line 730: 


....................................................
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/upgrade/dbvalidations.py
Line 159
Line 160
Line 161
Line 162
Line 163
I did not like 'db' and not 'user decided...' it has no actual meaning, so I 
dropped the entire line.


Line 136:             ] is None:
Line 137:                 self.logger.warn(
Line 138:                     _(
Line 139:                         'The following inconsistencies were found '
Line 140:                         'in engine database: {violations}. '
Done
Line 141:                     ).format(
Line 142:                         violations=violations,
Line 143:                     ),
Line 144:                 )


-- 
To view, visit http://gerrit.ovirt.org/22985
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c486ecf94e74cece79ba9260c50ac9ab1ba1d05
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to