Liran Zelkha has posted comments on this change.

Change subject: core: Adding an option to get a list of partial VDS
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDAODbFacadeImpl.java
Line 342:             // entity.setUsageMemPercent((Integer) rs
Line 343:             // .getObject("usage_mem_percent"));
Line 344:             // entity.setUsageNetworkPercent((Integer) rs
Line 345:             // .getObject("usage_network_percent"));
Line 346:             // entity.setMemAvailable(rs.getLong("mem_available"));
Actually - I'm still loading vds_statistics in the stored procedure, and just 
removed the mapping to check if it's still usable. I think it's not. The new 
version fixes this, I just need to check the performance - probably later 
today/early next week.
Line 347:             // entity.setMemShared(rs.getLong("mem_shared"));
Line 348:             entity.calculateFreeVirtualMemory();
Line 349: 
Line 350:             // None


-- 
To view, visit http://gerrit.ovirt.org/22810
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I20eabaf4531431b0adbaa85966d2cb095c70ec2d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to