Allon Mureinik has posted comments on this change. Change subject: restapi: Relax parameter checking for move disk ......................................................................
Patch Set 2: Juan, thanks for your feedback. The TestHelper eventually compares the two parameter instances field-by-field by using the method: protected static boolean matches(Object lhs, Object rhs) This method essentially does the following: - If the objects are not lists, use equals - If the objects are lists, for each value in lhs check that rhs contains's it, and compare the sizes. So here, when dealing with MoveDisksParameters, it's the only case where a parameter class has a member which is a list of parameter classes itself. In this usecase, when you apply the above logic, you end up comparing parameter classes with equals, which fails. -- To view, visit http://gerrit.ovirt.org/22963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If982d07ce83a225063c2ba3b8771e0f8384b1ea6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
