Vojtech Szocs has posted comments on this change. Change subject: doc: Update README.developer regarding GWT debug ......................................................................
Patch Set 1: (1 comment) .................................................... File README.developer Line 182: Line 183: Debug port is 8000, detailed instructions for GWT debugging are at [1]. Line 184: Line 185: GWT debug URLs, provided components running on same machine: Line 186: WebAdmin http://127.0.0.1:8080/ovirt-engine/webadmin/WebAdmin.html?gwt.codesvr=127.0.0.1:9997 OK, but what's the advantage of using URL that implicitly assumes <welcome-file-list> containing GWT host page (WebAdmin.html) for debugging purposes? When debugging GWT application, you need application's host page (WebAdmin.html) URL, I don't see a reason why we shouldn't be explicit in this particular case. Also imagine someone changes <welcome-file-list> - this would essentially break the debugging process. Line 187: UserPortal http://127.0.0.1:8080/ovirt-engine/userportal/UserPortal.html?gwt.codesvr=127.0.0.1:9997 Line 188: Line 189: [1] http://wiki.ovirt.org/DebugFrontend Line 190: -- To view, visit http://gerrit.ovirt.org/23024 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d8df4ea6fb8cc029d61d49fb4237ab6844d23a2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
