Oved Ourfali has submitted this change and it was merged. Change subject: engine: add checkstyle rule UncommentedMain ......................................................................
engine: add checkstyle rule UncommentedMain Enable the rule, remove unused main methods and suppress the validation for classes where the main method is needed. Change-Id: Ife8c381ec290214da66cb3df2aa3f29b7c57af98 Signed-off-by: Alissa Bonas <abo...@redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/CLIParser.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 4 files changed, 5 insertions(+), 28 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/23008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife8c381ec290214da66cb3df2aa3f29b7c57af98 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
