Allon Mureinik has uploaded a new change for review.
Change subject: core: findbugs: inconsistent synchronization
......................................................................
core: findbugs: inconsistent synchronization
AsyncTasksManager is currently the only class with suffers from
inconsistent synchronization. This patch does not solve those issues (in
an attempt to "not rock the boat", but preserve the current situation).
It does, however, move the exclusion of this check out of
exclude-filters-general.xml and fine-grains it to exclude only
AsyncTasksManager in order to avoid these potentially dangerous bugs in
future classes.
Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M backend/manager/modules/bll/exclude-filters.xml
M exclude-filters-general.xml
2 files changed, 4 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/35/23035/1
diff --git a/backend/manager/modules/bll/exclude-filters.xml
b/backend/manager/modules/bll/exclude-filters.xml
index 50eca8d..526d230 100644
--- a/backend/manager/modules/bll/exclude-filters.xml
+++ b/backend/manager/modules/bll/exclude-filters.xml
@@ -154,5 +154,8 @@
<Bug pattern="BC_UNCONFIRMED_CAST" />
</Match>
-
+ <Match>
+ <Class name="org.ovirt.engine.core.bll.AsyncTaskManager" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
</FindBugsFilter>
diff --git a/exclude-filters-general.xml b/exclude-filters-general.xml
index f0ba0ec..6fd4fe6 100644
--- a/exclude-filters-general.xml
+++ b/exclude-filters-general.xml
@@ -47,15 +47,6 @@
<!--
Currently Ignoring.
findbugs reason:
- IS: Inconsistent synchronization (IS2_INCONSISTENT_SYNC)
- -->
- <Match>
- <Bug code="IS" />
- </Match>
-
- <!--
- Currently Ignoring.
- findbugs reason:
REC: Exception is caught when Exception is not thrown (REC_CATCH_EXCEPTION)
-->
<Match>
--
To view, visit http://gerrit.ovirt.org/23035
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iafbd7c713584ca08b2e74617e289554425ac2b68
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
