Shubhendu Tripathi has posted comments on this change. Change subject: gluster: dao changes for volume capacity info ......................................................................
Patch Set 2: (3 comments) .................................................... Commit Message Line 8: Line 9: Adding volume capacity information as part of the Line 10: volumes tables. Necessary DAO changed are made to update/read Line 11: the capacity information. Line 12: : Remove the un-neccessary ":" Line 13: Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 .................................................... File packaging/dbscripts/create_views.sql Line 1600: vds_groups.name AS vds_group_name Line 1601: FROM gluster_volumes Line 1602: INNER JOIN vds_groups ON gluster_volumes.cluster_id = vds_groups.vds_group_id; Line 1603: Line 1604: CREATE OR REPLACE VIEW gluster_volumes_capacity_view We are getting all the fields of gluster_volumes in the view gluster_volumes_view already. Do we need this new one? Line 1605: AS Line 1606: SELECT gluster_volumes.id, Line 1607: gluster_volumes.total_space, Line 1608: gluster_volumes.used_space, .................................................... File packaging/dbscripts/gluster_volumes_sp.sql Line 408: WHERE id = v_id; Line 409: END; $procedure$ Line 410: LANGUAGE plpgsql; Line 411: Line 412: Create or replace FUNCTION UpdateGlusterVolumeCapacityInfo(v_id UUID, s/v_id/v_volume_id/g Line 413: v_total_space bigint, Line 414: v_used_space bigint, Line 415: v_free_space bigint) Line 416: RETURNS VOID -- To view, visit http://gerrit.ovirt.org/23010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d67b7ee22f4cb6839d0f14d3f27f3e22149ff22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
