Moti Asayag has posted comments on this change.

Change subject: engine: Support interface QoS override in Setup Networks
......................................................................


Patch Set 12:

(1 comment)

....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/CollectVdsNetworkDataVDSCommand.java
Line 187:                 VdsNetworkInterface vdsIface = 
hostNicsByNames.get(dbIface.getName());
Line 188: 
Line 189:                 // we preserve only the ID and the labels from the 
Database
Line 190:                 // everything else is what we got from 
getVdsCapabilities
Line 191:                 vdsIface.setId(dbIface.getId());
without preserving the QoS information from the DB entity, each 
refreshCapabilities will result in nullifying the qos data.
Line 192:                 vdsIface.setLabels(dbIface.getLabels());
Line 193:                 dbIfacesToBatch.add(vdsIface);
Line 194:                 updatedIfaces.add(vdsIface.getName());
Line 195:             } else {


-- 
To view, visit http://gerrit.ovirt.org/22766
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22a4fefac1c5e80c98a72507623152ea4d30ef07
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to