Ofer Schreiber has posted comments on this change. Change subject: tools: Separate tools into different packages (BZ803240) ......................................................................
Patch Set 1: Fails (1 inline comment) Code looks good to me, Good job Keith. single issue: we shouldn't drop the different Requires: (iso-uploader/log-collectory/image-uploader) from the spec file .................................................... File packaging/fedora/spec/ovirt-engine.spec.in Line 62 I'm pretty sure we would like to keep this. We're just not building these rpm in the same package, but we always want them in the ovirt-engine server -- To view, visit http://gerrit.ovirt.org/4194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab407ca53d21efd0e607f3ace3df2dfd54b83b68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Keith Robertson <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
