Eli Mesika has posted comments on this change. Change subject: core: handle only required networks which are down ......................................................................
Patch Set 4: (3 inline comments) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java Line 551: setHostDown = isRequiredInterfaceIsDown(networksByName, networks, nics, iface); method name still not OK , should be isRequiredInterfaceDow Line 691: * @return @return boolean Line 693: private boolean isRequiredInterfaceIsDown(Map<String, network> networksByName, method name still not OK , should be isRequiredInterfaceDow -- To view, visit http://gerrit.ovirt.org/3706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic9dafe147017d20e790813bc0edce9a06c228791 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
