Shubhendu Tripathi has posted comments on this change.

Change subject: gluster: VDS command for getting gluster volume capacity
......................................................................


Patch Set 15:

(2 comments)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
Line 76:     private Set<TransportType> transportTypes;
Line 77: 
Line 78:     private GlusterAsyncTask asyncTask;
Line 79: 
Line 80:     private GlusterVolumeSizeInfo capacityDetails;
This is required for uses in statistics REST query. This is not being stored in 
DB.
Line 81: 
Line 82:     public GlusterVolumeEntity() {
Line 83:         options = new LinkedHashMap<String, 
GlusterVolumeOptionEntity>();
Line 84:         bricks = new ArrayList<GlusterBrickEntity>();


....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeSizeInfo.java
Line 79:         if (!(volumeId.equals(sizeInfo.getVolumeId()))) {
Line 80:             return false;
Line 81:         }
Line 82: 
Line 83:         if (totalSize != sizeInfo.getTotalSize()) {
Will correct it.
Line 84:             return false;
Line 85:         }
Line 86: 
Line 87:         if (freeSize != sizeInfo.getFreeSize()) {


-- 
To view, visit http://gerrit.ovirt.org/18890
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide04bf31a4ee5b6579315371f09397142c58d9a3
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to