Mike Kolesnik has posted comments on this change. Change subject: engine: Prevent removing a labeled network ......................................................................
Patch Set 7: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java Line 478: NETWORK_MTU_DIFFERENCES(ErrorType.CONFLICT), Line 479: NETWORK_MTU_OVERRIDE_NOT_SUPPORTED(ErrorType.CONFLICT), Line 480: EXTERNAL_NETWORK_CANNOT_BE_PROVISIONED(ErrorType.NOT_SUPPORTED), Line 481: NETWORK_LABEL_FORMAT_INVALID(ErrorType.BAD_PARAMETERS), Line 482: ACTION_TYPE_FAILED_CANNOT_REMOVE_LABELED_NETWORK_FROM_NIC(ErrorType.BAD_PARAMETERS), Sounds to me more like ErrorType.CONFLICT Line 483: IMPROPER_INTERFACE_IS_LABELED(ErrorType.BAD_PARAMETERS), Line 484: INTERFACE_ALREADY_LABELED(ErrorType.BAD_PARAMETERS), Line 485: INTERFACE_NOT_LABELED(ErrorType.BAD_PARAMETERS), Line 486: ACTION_TYPE_FAILED_VNIC_PROFILE_NOT_EXISTS(ErrorType.BAD_PARAMETERS), -- To view, visit http://gerrit.ovirt.org/22941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I300c0327fcf838b7581ad5a7ec12ee6bd9b9f0b2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
