Martin Peřina has posted comments on this change. Change subject: packaging: services: systemd: convert deamons into notify type ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/pythonlib/ovirt_engine/service.py Line 391: os.umask(0o022) Line 392: Line 393: self.daemonSetup() Line 394: Line 395: self._daemonReady() Well, I think that we should send success on last possible moment, so systemd will display as much errors as possible during start command ... But in validation scenario you are right. Line 396: Line 397: stdout, stderr = (sys.stdout, sys.stderr) Line 398: if self._options.redirectOutput: Line 399: stdout, stderr = self.daemonStdHandles() -- To view, visit http://gerrit.ovirt.org/22632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I598a9d57c6dae6eb9d26c8ccca7ce22cdb1170a3 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
