Alon Bar-Lev has posted comments on this change.
Change subject: tools: support remote jvm debugging in ovirt-engine-notifier
......................................................................
Patch Set 2:
(4 comments)
....................................................
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
Line 34: #
Line 35: # Use this if you want to enable remote debugging of the notifier java
virtual
Line 36: # machine (useful mainly for developers):
Line 37: #
Line 38: # NOTIFIER_DEBUG_ADDRESS=localhost:8686
Add:
NOTIFIER_DEBUG_ADDRESS=
Line 39:
Line 40: #
Line 41: # Service timeouts
Line 42: #
....................................................
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.py
Line 130: jbossModulesJar=jbossModulesJar,
Line 131: )
Line 132:
Line 133: self._engineArgs = [
Line 134: # The name of the process, as displayed by ps:
not part of this patch, right?
Line 135: 'ovirt-engine-notifier',
Line 136:
Line 137: '-Dlog4j.configuration=file://%s/notifier/log4j.xml' % (
Line 138: self._config.get('ENGINE_ETC'),
Line 132:
Line 133: self._engineArgs = [
Line 134: # The name of the process, as displayed by ps:
Line 135: 'ovirt-engine-notifier',
Line 136:
not part of this patch, right?
Line 137: '-Dlog4j.configuration=file://%s/notifier/log4j.xml' % (
Line 138: self._config.get('ENGINE_ETC'),
Line 139: ),
Line 140: '-Djboss.modules.write-indexes=false'
Line 136:
Line 137: '-Dlog4j.configuration=file://%s/notifier/log4j.xml' % (
Line 138: self._config.get('ENGINE_ETC'),
Line 139: ),
Line 140: '-Djboss.modules.write-indexes=false'
always have comma at end
Line 141: ]
Line 142:
Line 143: debugAddress = self._config.get('NOTIFIER_DEBUG_ADDRESS')
Line 144: if debugAddress:
--
To view, visit http://gerrit.ovirt.org/22981
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ecdd650763e00db1d85b36c3b6d2f48924e7935
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
