Moti Asayag has uploaded a new change for review. Change subject: engine: Fix coverity warnings ......................................................................
engine: Fix coverity warnings Fixed the following: 1. Inner class should be static 2. A private field should be accessed Change-Id: I998f955a42cf930fdec73ed44a0114fdbbcc4fe2 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/80/22980/1 diff --git a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java index d8b82b5..c63d97c 100644 --- a/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java +++ b/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidNameValidatorTest.java @@ -34,8 +34,9 @@ @Test public void checkName() { - Set<ConstraintViolation<ValidNameContainer>> result = validator.validate(new ValidNameContainer(name)); - assertEquals(expectedResult, result.isEmpty()); + ValidNameContainer container = new ValidNameContainer(name); + Set<ConstraintViolation<ValidNameContainer>> result = validator.validate(container); + assertEquals("Failed to validate name: " + container.getName(), expectedResult, result.isEmpty()); } @Parameterized.Parameters @@ -55,7 +56,7 @@ }); } - private class ValidNameContainer { + private static class ValidNameContainer { @ValidName private String name; @@ -63,5 +64,9 @@ public ValidNameContainer(String name) { this.name = name; } + + public String getName() { + return name; + } } } -- To view, visit http://gerrit.ovirt.org/22980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I998f955a42cf930fdec73ed44a0114fdbbcc4fe2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
