Lior Vernia has uploaded a new change for review.
Change subject: webadmin: Small improvements to ListModelSuggestBox
......................................................................
webadmin: Small improvements to ListModelSuggestBox
Made the widget more responsive, so that on each key press a
ValueChangedEvent is fired. Also made the implementation of
addValueChangeHandler in BaseListModelSuggestBox more standard.
Change-Id: Iadf50caf19cac07f1d65a20557276a6c4b4f8b70
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java
2 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/22972/1
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
index 93b1690..46d68b6 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/BaseListModelSuggestBox.java
@@ -170,7 +170,7 @@
public void onValueChange(ValueChangeEvent<String> event) {
try {
T value = asEntity(event.getValue());
- handler.onValueChange(new ValueChangeEvent<T>(value) {});
+ ValueChangeEvent.fire(BaseListModelSuggestBox.this, value);
} catch (IllegalArgumentException e) {
// ignore - the user entered an incorrect string. Just do
not notify the listeners
}
diff --git
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java
index 5d2de01..e07ab2b 100644
---
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java
+++
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/generic/ListModelSuggestBox.java
@@ -1,7 +1,12 @@
package org.ovirt.engine.ui.common.widget.editor.generic;
+import com.google.gwt.core.client.Scheduler;
+import com.google.gwt.core.client.Scheduler.ScheduledCommand;
import com.google.gwt.event.dom.client.FocusEvent;
import com.google.gwt.event.dom.client.FocusHandler;
+import com.google.gwt.event.dom.client.KeyPressEvent;
+import com.google.gwt.event.dom.client.KeyPressHandler;
+import com.google.gwt.event.logical.shared.ValueChangeEvent;
import com.google.gwt.user.client.ui.MultiWordSuggestOracle;
import java.util.Collection;
import org.ovirt.engine.ui.common.widget.editor.BaseListModelSuggestBox;
@@ -22,6 +27,19 @@
asSuggestBox().showSuggestionList();
}
});
+ addKeyPressHandler(new KeyPressHandler() {
+
+ @Override
+ public void onKeyPress(KeyPressEvent event) {
+ Scheduler.get().scheduleDeferred(new ScheduledCommand() {
+
+ @Override
+ public void execute() {
+ ValueChangeEvent.fire(ListModelSuggestBox.this,
asSuggestBox().getText());
+ }
+ });
+ }
+ });
}
@Override
--
To view, visit http://gerrit.ovirt.org/22972
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadf50caf19cac07f1d65a20557276a6c4b4f8b70
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
