Moti Asayag has posted comments on this change.

Change subject: engine: Command for adding external subnets
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddSubnetToProviderCommand.java
Line 32: 
Line 33: 
Line 34:     private Provider<?> getProvider() {
Line 35:         if (provider == null) {
Line 36:             provider = 
getDbFacade().getProviderDao().get(getExternalNetwork().getProviderId());
if getExternalNetwork() returns null, you'll end up with NPE.
Line 37:         }
Line 38: 
Line 39:         return provider;
Line 40:     }


-- 
To view, visit http://gerrit.ovirt.org/22688
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92ac30f46c1aa20677da34719fd33eec6b964899
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to