Kiril Nesenko has posted comments on this change.

Change subject: Change versioning schema and fix tarball
......................................................................


Patch Set 7:

(6 comments)

....................................................
File AUTHORS
Line 1: The following people have contributed to this project.
Line 2: 
Line 3: * Kiril Nesenko <knese...@redhat.com>
No problem !


....................................................
File Makefile.am
Line 64: rpm:   srpm
Line 65:        rpmbuild --define="_topdir `pwd`/$(TMPREPOS)" --rebuild 
"$(TMPREPOS)"/SRPMS/*.src.rpm
Line 66:        @echo
Line 67:        @echo "rpm(s) available at '$(TMPREPOS)'"
Line 68:        @echo
standard sequence is: make dist; rpmbuild .... ?


....................................................
File configure.ac
Line 9: define([VERSION_SUFFIX], [_master])
Line 10: 
Line 11: AC_INIT([mom], VERSION_NUMBER[]VERSION_SUFFIX, 
[mom-de...@googlegroups.com])
Line 12: PACKAGE_RPM_VERSION="VERSION_NUMBER"
Line 13: PACKAGE_RPM_RELEASE="3.20.$(echo VERSION_SUFFIX | sed 's/^_//')"
this version came from your code. I just put it here
Line 14: PACKAGE_NAME="mom"
Line 15: AC_SUBST([PACKAGE_NAME])
Line 16: AC_SUBST([PACKAGE_RPM_VERSION])
Line 17: AC_SUBST([PACKAGE_RPM_RELEASE])


....................................................
File mom.spec.in
Line 70
Line 71
Line 72
Line 73
Line 74
Done


Line 75
Line 76
Line 77
Line 78
Line 79
Done


Line 76
Line 77
Line 78
Line 79
Line 80
Done


-- 
To view, visit http://gerrit.ovirt.org/22874
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4337150f58cd7d9b3a04a12a3afa9acd8a826a22
Gerrit-PatchSet: 7
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to