Mike Kolesnik has posted comments on this change.
Change subject: engine: Moved more QoS validation to NetworkQosValidator
......................................................................
Patch Set 6:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/NetworkQosValidatorTest.java
Line 111:
Line 112: @Test
Line 113: public void onlyAveragePresent() {
Line 114: qos.setInboundAverage(BANDWIDTH_MEDIUM);
Line 115:
valuesPresentTest(failsWith(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES));
Please test all permutations of in & out values
Line 116: }
Line 117:
Line 118: @Test
Line 119: public void burstMissing() {
Line 145: }
Line 146:
Line 147: @Test
Line 148: public void peakLowerThanAverage() {
Line 149: qos.setInboundPeak(BANDWIDTH_LOW);
Please test also outbound peak..
Line 150:
peakConsistentWithAverageTest(failsWith(VdcBllMessages.ACTION_TYPE_FAILED_NETWORK_QOS_PEAK_LOWER_THAN_AVERAGE));
Line 151: }
--
To view, visit http://gerrit.ovirt.org/22765
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b5b374ff7da21de19851bdff6df4a2f53f0dd0e
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
