Juan Hernandez has uploaded a new change for review.

Change subject: codegen: Allow connection to SSL servers
......................................................................

codegen: Allow connection to SSL servers

Currently the generator connects to a live engine using HTTP, without
SSL. This isn't the default configuration for a freshly installed
engine, so it makes generation a bit more complicated. This patch adds
support for connecting to a SSL protected server without verification.

Change-Id: I35ddfac416464876685b5e63b241db47e401626d
Signed-off-by: Juan Hernandez <juan.hernan...@redhat.com>
---
M 
ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
1 file changed, 8 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk-java 
refs/changes/45/22945/1

diff --git 
a/ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
 
b/ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
index b30328f..606820c 100644
--- 
a/ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
+++ 
b/ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/Main.java
@@ -23,6 +23,7 @@
 import org.ovirt.engine.sdk.codegen.rsdl.RsdlCodegen;
 import org.ovirt.engine.sdk.codegen.xsd.XsdCodegen;
 import org.ovirt.engine.sdk.exceptions.ServerException;
+import org.ovirt.engine.sdk.web.ConnectionsPool;
 import org.ovirt.engine.sdk.web.ConnectionsPoolBuilder;
 import org.ovirt.engine.sdk.web.HttpProxyBroker;
 import org.ovirt.engine.sdk.web.HttpProxyBuilder;
@@ -66,10 +67,14 @@
             }
         }
 
+        // Create a connection pool that allows us to connect to SSL protected 
servers without verificating the host
+        // name, as this verification is an unnecessary complication for the 
code generator:
+        ConnectionsPool pool = new ConnectionsPoolBuilder(url, user, password)
+            .noHostVerification(true)
+            .build();
+
         HttpProxyBroker httpProxyBroker = new HttpProxyBroker(
-                new HttpProxyBuilder(
-                        new ConnectionsPoolBuilder(url, user, password).build()
-                ).build());
+                new HttpProxyBuilder(pool).build());
 
         // #1 - generate api entities from the XSD schema
         new XsdCodegen(httpProxyBroker).generate();


-- 
To view, visit http://gerrit.ovirt.org/22945
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35ddfac416464876685b5e63b241db47e401626d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to