Adam Litke has uploaded a new change for review.
Change subject: pep8: Fix exportfs.py
......................................................................
pep8: Fix exportfs.py
The backend currently fails to build due to pep8 violations in
exportfs.py. Reformat the comment block to bring the file into
compliance. Also, remove extra whitespace around a dictionary
declaration.
Change-Id: Ied89b1ee15d3df1a85e8d4dfc8316a0a2e09be90
Signed-off-by: Adam Litke <ali...@redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/38/22938/1
diff --git
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
index b3e0b68..e8f755a 100644
--- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
+++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
@@ -148,11 +148,12 @@
)
if self._conf == osetupcons.FileLocations.OVIRT_NFS_EXPORT_FILE:
if exports_index is not None:
- # This probably means that in a previous setup we added the
path
- # to /etc/exports instead of creating our own file in
- # /etc/exports.d as we do now. Delete the line from
/etc/exports.
- # The transaction below does not pass modifiedList nor do we
call
- # addChanges - we do not revert this fix on cleanup.
+ # This probably means that in a previous setup we added the
+ # path to /etc/exports instead of creating our own file in
+ # /etc/exports.d as we do now. Delete the line from
+ # /etc/exports. The transaction below does not pass
+ # modifiedList nor do we call addChanges - we do not
+ # revert this fix on cleanup.
del exports_content[exports_index]
self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
filetransaction.FileTransaction(
@@ -166,7 +167,7 @@
new_line,
]
else:
- changes = { 'added': new_line }
+ changes = {'added': new_line}
if exports_index is not None:
old_line = exports_content.pop(exports_index)
changes['removed'] = old_line
--
To view, visit http://gerrit.ovirt.org/22938
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied89b1ee15d3df1a85e8d4dfc8316a0a2e09be90
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
