Douglas Schilling Landgraf has uploaded a new change for review.

Change subject: packaging: fix pep8 complains about exportsfs.py
......................................................................

packaging: fix pep8 complains about exportsfs.py

- line over 80
- whitespace in '{' and '}'

Change-Id: I35b35f4aebf1c9959f104ee734d858a7f53a03d6
Signed-off-by: Douglas Schilling Landgraf <dougsl...@redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/22933/1

diff --git 
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
index b3e0b68..1df48d3 100644
--- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
+++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/exportfs.py
@@ -148,11 +148,12 @@
         )
         if self._conf == osetupcons.FileLocations.OVIRT_NFS_EXPORT_FILE:
             if exports_index is not None:
-                # This probably means that in a previous setup we added the 
path
-                # to /etc/exports instead of creating our own file in
-                # /etc/exports.d as we do now. Delete the line from 
/etc/exports.
-                # The transaction below does not pass modifiedList nor do we 
call
-                # addChanges - we do not revert this fix on cleanup.
+                # This probably means that in a previous setup we added the
+                # path to /etc/exports instead of creating our own file in
+                # /etc/exports.d as we do now. Delete the line from
+                # /etc/exports. The transaction below does not pass
+                # modifiedList nor do we call addChanges - we do not revert
+                # this fix on cleanup.
                 del exports_content[exports_index]
                 self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append(
                     filetransaction.FileTransaction(
@@ -166,7 +167,7 @@
                 new_line,
             ]
         else:
-            changes = { 'added': new_line }
+            changes = {'added': new_line}
             if exports_index is not None:
                 old_line = exports_content.pop(exports_index)
                 changes['removed'] = old_line


-- 
To view, visit http://gerrit.ovirt.org/22933
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I35b35f4aebf1c9959f104ee734d858a7f53a03d6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to