Moti Asayag has uploaded a new change for review. Change subject: core: Clear coverity warning ......................................................................
core: Clear coverity warning Coverity complains that RemoveNetworkParameters doesn't override VdcActionParametersBase.equals(Object) Change-Id: I41e00d5e3be113ea5c2dbacbab4cb5fddbf32803 Signed-off-by: Moti Asayag <masa...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/30/22930/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java index 3f95eed..51c09d8 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveNetworkParameters.java @@ -39,4 +39,32 @@ public void setRemoveFromNetworkProvider(boolean removeFromNetworkProvider) { this.removeFromNetworkProvider = removeFromNetworkProvider; } + + @Override + public int hashCode() { + final int prime = 31; + int result = super.hashCode(); + result = prime * result + ((getId() == null) ? 0 : getId().hashCode()); + result = prime * result + (isRemoveFromNetworkProvider() ? 1231 : 1237); + return result; + } + + @Override + public boolean equals(Object obj) { + if (this == obj) + return true; + if (!super.equals(obj)) + return false; + if (getClass() != obj.getClass()) + return false; + RemoveNetworkParameters other = (RemoveNetworkParameters) obj; + if (getId() == null) { + if (other.getId() != null) + return false; + } else if (!getId().equals(other.getId())) + return false; + if (isRemoveFromNetworkProvider() != other.isRemoveFromNetworkProvider()) + return false; + return true; + } } -- To view, visit http://gerrit.ovirt.org/22930 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I41e00d5e3be113ea5c2dbacbab4cb5fddbf32803 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches