mooli tayer has posted comments on this change. Change subject: Add snmp4j dependency in tools module. ......................................................................
Patch Set 5: (2 comments) I'm not sure what you mean? the java code that was here previously? if so It implements snmp in notifier and most of it is a refactor of the notifier. I will try to separate patches as best as I can. good chance to learn how to do that. .................................................... File backend/manager/tools/pom.xml Line 23: <id>snmp4j</id> Line 24: <name>snmp4j</name> Line 25: <url>https://oosnmp.net/dist/release/</url> Line 26: <snapshots> Line 27: <enabled>false</enabled> I think the default is true http://maven.apache.org/ref/3.1.1/maven-settings/settings.html#class_snapshots ? Line 28: </snapshots> Line 29: </repository> Line 30: </repositories> Line 31: .................................................... File ovirt-engine.spec.in Line 207: Requires: springframework-instrument Line 208: Requires: springframework-jdbc Line 209: Requires: springframework-tx Line 210: Requires: xmlrpc-client Line 211: Requires: snmp4j My change to tab seems to be ignored. I will resolve this. Line 212: %endif Line 213: %endif Line 214: Line 215: # We can't require exactly the same version and release of the -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
