Lior Vernia has posted comments on this change. Change subject: core: Allow anonymous QoS in DB ......................................................................
Patch Set 11: Firstly, I think your comments are not referring this patch; lifting the DB constraints is also necessary just to monitor the runtime configuration of a host. I think your problems are with this: http://gerrit.ovirt.org/#/c/22766/ Secondly, does the VM scheduler currently refer to QoS configuration on a host? As far as I know it doesn't, so even if we only allowed named, DC-bound shared entities, migration wouldn't consider them either. Looking into the future, if the scheduler does take this into consideration, then I don't see any obstacle that's too difficult to overcome. If the scheduler's looking at the host's QoS configuration anyway to determine if it's right for a VM, then it might as well look at the relevant host interface as well. -- To view, visit http://gerrit.ovirt.org/22601 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1041fcd790ff1f32b87bf68e8948cb16bcf623 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Livnat Peer <lp...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches