Omer Frenkel has posted comments on this change.
Change subject: engine: Track the time a VM was last stopped
......................................................................
Patch Set 2:
(1 comment)
just one comment, other than that, looks good, thanks!
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 749: tempVar.setVmHost("");
Line 750: tempVar.setVmIp("");
Line 751: tempVar.setVmFQDN("");
Line 752:
tempVar.setDisplayType(getParameters().getVmStaticData().getDefaultDisplayType());
Line 753: tempVar.setLastStopTime(new Date());
i guess this is needed in importVmCommand as well
Line 754: VmDynamic vmDynamic = tempVar;
Line 755: DbFacade.getInstance().getVmDynamicDao().save(vmDynamic);
Line 756: getCompensationContext().snapshotNewEntity(vmDynamic);
Line 757: }
--
To view, visit http://gerrit.ovirt.org/22429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f94a56e0c82246a932fc1800a2c9ef8c5205e13
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
